Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 48627d8d authored by Thomas Gleixner's avatar Thomas Gleixner
Browse files

genirq: remove extraneous checks in manage.c 

In http://bugzilla.kernel.org/show_bug.cgi?id=9580

 it was pointed out
that the desc->chip checks are extraneous. In fact these are left
overs from early development and can be removed safely.

Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
parent 18404756

kernel/irq/manage.c

+2 −3
Original line number Original line Diff line number Diff line
@@ -377,7 +377,7 @@ int setup_irq(unsigned int irq, struct irqaction *new) 




		/* Setup the type (level, edge polarity) if configured: */

		/* Setup the type (level, edge polarity) if configured: */

		if (new->flags & IRQF_TRIGGER_MASK) {

		if (new->flags & IRQF_TRIGGER_MASK) {

			if (desc->chip && desc->chip->set_type)

			if (desc->chip->set_type)

				desc->chip->set_type(irq,

				desc->chip->set_type(irq,

						new->flags & IRQF_TRIGGER_MASK);

						new->flags & IRQF_TRIGGER_MASK);

			else

			else
@@ -387,8 +387,7 @@ int setup_irq(unsigned int irq, struct irqaction *new) 
				 */

				 */

				printk(KERN_WARNING "No IRQF_TRIGGER set_type "

				printk(KERN_WARNING "No IRQF_TRIGGER set_type "

				       "function for IRQ %d (%s)\n", irq,

				       "function for IRQ %d (%s)\n", irq,

				       desc->chip ? desc->chip->name :

				       desc->chip->name);

				       "unknown");

		} else

		} else

			compat_irq_chip_set_default_handler(desc);

			compat_irq_chip_set_default_handler(desc);