Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 485b099a authored by Anatoly Stepanov's avatar Anatoly Stepanov Committed by Greg Kroah-Hartman
Browse files

staging: rtl8723au: change parameter type in rtl8723a_set_rssi_cmd declaration 



Previosly the function had the following prototype:
int rtl8723a_set_rssi_cmd(struct rtw_adapter *padapter, u8 *param)

My suggestion here is to modify the prototype this way:
int rtl8723a_set_rssi_cmd(struct rtw_adapter *padapter, u32 param)

We can do this based on the following considerations:
1. rtl8723a_set_rssi_cmd is used only with 32-bit "param" values
2. There's no point in using "u8 *param" until we pass param length
3. As we just read "param", it's ok to pass it by value

Signed-off-by: default avatarAnatoly Stepanov <drivengroove@gmail.com>
Acked-by: default avatarJes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 3d7a8477

drivers/staging/rtl8723au/hal/odm.c

+1 −1
Original line number Diff line number Diff line
@@ -1274,7 +1274,7 @@ static void odm_RSSIMonitorCheck(struct dm_odm_t *pDM_Odm) 


	for (i = 0; i < sta_cnt; i++) {

		if (PWDB_rssi[i] != (0))

			rtl8723a_set_rssi_cmd(Adapter, (u8 *)&PWDB_rssi[i]);

			rtl8723a_set_rssi_cmd(Adapter, PWDB_rssi[i]);

	}



	pdmpriv->EntryMaxUndecoratedSmoothedPWDB = MaxDB;

drivers/staging/rtl8723au/hal/rtl8723a_cmd.c

+3 −3
Original line number Diff line number Diff line
@@ -113,11 +113,11 @@ int FillH2CCmd(struct rtw_adapter *padapter, u8 ElementID, u32 CmdLen, 
	return ret;

}



int rtl8723a_set_rssi_cmd(struct rtw_adapter *padapter, u8 *param)

int rtl8723a_set_rssi_cmd(struct rtw_adapter *padapter, u32 param)

{

	*((u32 *)param) = cpu_to_le32(*((u32 *)param));

	__le32 cmd = cpu_to_le32(param);



	FillH2CCmd(padapter, RSSI_SETTING_EID, 3, param);

	FillH2CCmd(padapter, RSSI_SETTING_EID, 3, (void *)&cmd);



	return _SUCCESS;

}

drivers/staging/rtl8723au/include/rtl8723a_cmd.h

+1 −1
Original line number Diff line number Diff line
@@ -149,7 +149,7 @@ void rtl8723a_set_BTCoex_AP_mode_FwRsvdPkt_cmd(struct rtw_adapter *padapter); 
#else

#define rtl8723a_set_BTCoex_AP_mode_FwRsvdPkt_cmd(padapter) do {} while(0)

#endif

int rtl8723a_set_rssi_cmd(struct rtw_adapter *padapter, u8 *param);

int rtl8723a_set_rssi_cmd(struct rtw_adapter *padapter, u32 param);

int rtl8723a_set_raid_cmd(struct rtw_adapter *padapter, u32 mask, u8 arg);

void rtl8723a_add_rateatid(struct rtw_adapter *padapter, u32 bitmap, u8 arg, u8 rssi_level);