Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 48559af3 authored by YueHaibing's avatar YueHaibing Committed by David S. Miller
Browse files

bnxt_en: remove redundant debug register dma mem allocation 



hwrm_dbg_resp_addr and hwrm_dbg_resp_dma_addr are never used
and can be removed.

Signed-off-by: default avatarYueHaibing <yuehaibing@huawei.com>
Acked-by: default avatarMichael Chan <michael.chan@broadcom.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 6e85d7a8

drivers/net/ethernet/broadcom/bnxt/bnxt.c

+0 −13
Original line number Diff line number Diff line
@@ -3012,13 +3012,6 @@ static void bnxt_free_hwrm_resources(struct bnxt *bp) 
			  bp->hwrm_cmd_resp_dma_addr);



	bp->hwrm_cmd_resp_addr = NULL;

	if (bp->hwrm_dbg_resp_addr) {

		dma_free_coherent(&pdev->dev, HWRM_DBG_REG_BUF_SIZE,

				  bp->hwrm_dbg_resp_addr,

				  bp->hwrm_dbg_resp_dma_addr);



		bp->hwrm_dbg_resp_addr = NULL;

	}

}



static int bnxt_alloc_hwrm_resources(struct bnxt *bp)
@@ -3030,12 +3023,6 @@ static int bnxt_alloc_hwrm_resources(struct bnxt *bp) 
						   GFP_KERNEL);

	if (!bp->hwrm_cmd_resp_addr)

		return -ENOMEM;

	bp->hwrm_dbg_resp_addr = dma_alloc_coherent(&pdev->dev,

						    HWRM_DBG_REG_BUF_SIZE,

						    &bp->hwrm_dbg_resp_dma_addr,

						    GFP_KERNEL);

	if (!bp->hwrm_dbg_resp_addr)

		netdev_warn(bp->dev, "fail to alloc debug register dma mem\n");



	return 0;

}

drivers/net/ethernet/broadcom/bnxt/bnxt.h

+0 −3
Original line number Diff line number Diff line
@@ -1287,9 +1287,6 @@ struct bnxt { 
	dma_addr_t		hwrm_short_cmd_req_dma_addr;

	void			*hwrm_cmd_resp_addr;

	dma_addr_t		hwrm_cmd_resp_dma_addr;

	void			*hwrm_dbg_resp_addr;

	dma_addr_t		hwrm_dbg_resp_dma_addr;

#define HWRM_DBG_REG_BUF_SIZE	128



	struct rx_port_stats	*hw_rx_port_stats;

	struct tx_port_stats	*hw_tx_port_stats;