Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 483635a9 authored by Jiri Olsa's avatar Jiri Olsa Committed by Arnaldo Carvalho de Melo
Browse files

perf record: Add -a as default target 



Running 'perf record' with no target (-a, -p, -t, etc) will now collect
system wide data.

Commiter notes:

Testing it:

  [root@jouet ~]# perf record
  ^C[ perf record: Woken up 1 times to write data ]
  [ perf record: Captured and wrote 1.351 MB perf.data (366 samples) ]
  #

is equivalent to:

  # perf record -a
  ^C[ perf record: Woken up 1 times to write data ]
  [ perf record: Captured and wrote 1.411 MB perf.data (978 samples) ]
  #

Signed-off-by: default avatarJiri Olsa <jolsa@kernel.org>
Tested-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
Cc: Borislav Petkov <bp@alien8.de>
Cc: David Ahern <dsahern@gmail.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/20170217170018.GA15389@krava


Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
parent 0d79f8b9

tools/perf/Documentation/perf-record.txt

+1 −1
Original line number Original line Diff line number Diff line
@@ -157,7 +157,7 @@ OPTIONS 




-a::

-a::

--all-cpus::

--all-cpus::

        System-wide collection from all CPUs.

        System-wide collection from all CPUs (default if no target is specified).





-p::

-p::

--pid=::

--pid=::

tools/perf/builtin-record.c

+3 −1
Original line number Original line Diff line number Diff line
@@ -1677,8 +1677,10 @@ int cmd_record(int argc, const char **argv, const char *prefix __maybe_unused) 




	argc = parse_options(argc, argv, record_options, record_usage,

	argc = parse_options(argc, argv, record_options, record_usage,

			    PARSE_OPT_STOP_AT_NON_OPTION);

			    PARSE_OPT_STOP_AT_NON_OPTION);



	/* Make system wide (-a) the default target. */

	if (!argc && target__none(&rec->opts.target))

	if (!argc && target__none(&rec->opts.target))

		usage_with_options(record_usage, record_options);

		rec->opts.target.system_wide = true;





	if (nr_cgroups && !rec->opts.target.system_wide) {

	if (nr_cgroups && !rec->opts.target.system_wide) {

		usage_with_options_msg(record_usage, record_options,

		usage_with_options_msg(record_usage, record_options,