Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4801ae70 authored by Eugenia Emantayev's avatar Eugenia Emantayev Committed by David S. Miller
Browse files

net/mlx4_en: Move register_netdev() to the end of initialization function 



To avoid a race between the open function and everything that happens after
register_netdev() move it to be the last operation called.

Signed-off-by: default avatarEugenia Emantayev <eugenia@mellanox.com>
Signed-off-by: default avatarAmir Vadai <amirv@mellanox.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 6123db2e

drivers/net/ethernet/mellanox/mlx4/en_netdev.c

+2 −1
Original line number Diff line number Diff line
@@ -2323,6 +2323,8 @@ int mlx4_en_init_netdev(struct mlx4_en_dev *mdev, int port, 
	mdev->pndev[port] = dev;



	netif_carrier_off(dev);

	mlx4_en_set_default_moderation(priv);



	err = register_netdev(dev);

	if (err) {

		en_err(priv, "Netdev registration failed for port %d\n", port);
@@ -2354,7 +2356,6 @@ int mlx4_en_init_netdev(struct mlx4_en_dev *mdev, int port, 
		en_err(priv, "Failed Initializing port\n");

		goto out;

	}

	mlx4_en_set_default_moderation(priv);

	queue_delayed_work(mdev->workqueue, &priv->stats_task, STATS_DELAY);



	if (mdev->dev->caps.flags2 & MLX4_DEV_CAP_FLAG2_TS)