Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4753d8a2 authored by Theodore Ts'o's avatar Theodore Ts'o
Browse files

ext4: return EROFS if device is r/o and journal replay is needed 



If the file system requires journal recovery, and the device is
read-ony, return EROFS to the mount system call.  This allows xfstests
generic/050 to pass.

Signed-off-by: default avatarTheodore Ts'o <tytso@mit.edu>
Cc: stable@vger.kernel.org
parent 97abd7d4

fs/ext4/super.c

+2 −1
Original line number Diff line number Diff line
@@ -3925,7 +3925,8 @@ static int ext4_fill_super(struct super_block *sb, void *data, int silent) 
	 * root first: it may be modified in the journal!

	 */

	if (!test_opt(sb, NOLOAD) && ext4_has_feature_journal(sb)) {

		if (ext4_load_journal(sb, es, journal_devnum))

		err = ext4_load_journal(sb, es, journal_devnum);

		if (err)

			goto failed_mount3a;

	} else if (test_opt(sb, NOLOAD) && !(sb->s_flags & MS_RDONLY) &&

		   ext4_has_feature_journal_needs_recovery(sb)) {