Commit 4732cc63 authored Aug 04, 2012 by Arnd Bergmann

spi/s3c64xx: improve error handling



When a device tree definition os an s3c64xx SPI master is missing
a "controller-data" subnode, the newly added s3c64xx_get_slave_ctrldata
function might use uninitialized memory in place of that node,
which was correctly reported by gcc.

Without this patch, building s3c6400_defconfig results in:

drivers/spi/spi-s3c64xx.c: In function 's3c64xx_get_slave_ctrldata.isra.25':
drivers/spi/spi-s3c64xx.c:841:5: warning: 'data_np' may be used uninitialized in this function [-Wuninitialized]

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Thomas Abraham <thomas.abraham@linaro.org>
Acked-by: Kukjin Kim <kgene.kim@samsung.com>
Cc: Jaswinder Singh <jaswinder.singh@linaro.org>
Cc: Grant Likely <grant.likely@secretlab.ca>

parent d680e2c1

drivers/spi/spi-s3c64xx.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -826,7 +826,7 @@ static struct s3c64xx_spi_csinfo *s3c64xx_get_slave_ctrldata(
		struct spi_device *spi)
		{
		struct s3c64xx_spi_csinfo *cs;
		struct device_node slave_np, data_np;
		struct device_node slave_np, data_np = NULL;
		u32 fb_delay = 0;

		slave_np = spi->dev.of_node;