Commit 47229ff8 authored Jun 21, 2013 by Simon Derr Committed by Eric Van Hensbergen Jul 07, 2013

9P/RDMA: Protect against duplicate replies



A well-behaved server would not send twice the reply to a request.
But if it ever happens...
This additional check prevents the kernel from leaking memory
and possibly more nasty consequences in that unlikely event.

Signed-off-by: Simon Derr <simon.derr@bull.net>
Signed-off-by: Eric Van Hensbergen <ericvh@gmail.com>

parent 3fcc62f4

net/9p/trans_rdma.c

+7 −0

Original line number	Diff line number	Diff line
		@@ -294,6 +294,13 @@ handle_recv(struct p9_client client, struct p9_trans_rdma rdma,
		if (!req)
		goto err_out;

		/* Check that we have not yet received a reply for this request.
		*/
		if (unlikely(req->rc)) {
		pr_err("Duplicate reply for request %d", tag);
		goto err_out;
		}

		req->rc = c->rc;
		req->status = REQ_STATUS_RCVD;
		p9_client_cb(client, req);