Commit 45a6b821 authored Oct 26, 2015 by Matt Ranostay Committed by Jonathan Cameron Nov 21, 2015

iio: lidar: return -EINVAL on invalid signal



Returning zero from the measurment function has the side effect of
corrupting the triggered buffer readings, better to use -EINVAL than
a zero measurement reading.

The INVALID status happens even it isn't out of range
sometimes roughly once every second or two. This can be from an
invalid second signal return path. Hence there are spurious zero
readings from the triggered buffer, and warning messages in the kernel
log.

Signed-off-by: Matt Ranostay <mranostay@gmail.com>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>

parent 2e9fed42

drivers/iio/proximity/pulsedlight-lidar-lite-v2.c

+3 −3

Original line number	Diff line number	Diff line
		@@ -130,10 +130,10 @@ static int lidar_get_measurement(struct lidar_data data, u16 reg)
		if (ret < 0)
		break;

		/* return 0 since laser is likely pointed out of range */
		/* return -EINVAL since laser is likely pointed out of range */
		if (ret & LIDAR_REG_STATUS_INVALID) {
		*reg = 0;
		ret = 0;
		ret = -EINVAL;
		break;
		}

		@@ -197,7 +197,7 @@ static irqreturn_t lidar_trigger_handler(int irq, void *private)
		if (!ret) {
		iio_push_to_buffers_with_timestamp(indio_dev, data->buffer,
		iio_get_time_ns());
		} else {
		} else if (ret != -EINVAL) {
		dev_err(&data->client->dev, "cannot read LIDAR measurement");
		}