Commit 442bb53f authored Jun 14, 2020 by Qiushi Wu Committed by Greg Kroah-Hartman Oct 29, 2020

media: platform: fcp: Fix a reference count leak.



[ Upstream commit 63e36a381d92a9cded97e90d481ee22566557dd1 ]

pm_runtime_get_sync() increments the runtime PM usage counter even
when it returns an error code, causing incorrect ref count if
pm_runtime_put_noidle() is not called in error handling paths.
Thus call pm_runtime_put_noidle() if pm_runtime_get_sync() fails.

Fixes: 6eaafbdb ("[media] v4l: rcar-fcp: Keep the coding style consistent")
Signed-off-by: Qiushi Wu <wu000273@umn.edu>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 8ead1800

drivers/media/platform/rcar-fcp.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -103,8 +103,10 @@ int rcar_fcp_enable(struct rcar_fcp_device *fcp)
		return 0;

		ret = pm_runtime_get_sync(fcp->dev);
		if (ret < 0)
		if (ret < 0) {
		pm_runtime_put_noidle(fcp->dev);
		return ret;
		}

		return 0;
		}