Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4416f89b authored by Nicholas Bellinger's avatar Nicholas Bellinger
Browse files

target: Attach EXTENDED_COPY local I/O descriptors to xcopy_pt_sess 



This patch is a >= v4.1 regression bug-fix where control CDB
emulation logic in commit 38b57f82 now expects a se_cmd->se_sess
pointer to exist when determining T10-PI support is to be exposed
for initiator host ports.

To address this bug, go ahead and add locally generated se_cmd
descriptors for copy-offload block-copy to it's own stand-alone
se_session nexus, while the parent EXTENDED_COPY se_cmd descriptor
remains associated with it's originating se_cmd->se_sess nexus.

Note a valid se_cmd->se_sess is also required for future support
of WRITE_INSERT and READ_STRIP software emulation when submitting
backend I/O to se_device that exposes T10-PI suport.

Reported-by: default avatarAlex Gorbachev <ag@iss-integration.com>
Tested-by: default avatarAlex Gorbachev <ag@iss-integration.com>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: Hannes Reinecke <hare@suse.de>
Cc: Christoph Hellwig <hch@lst.de>
Cc: Doug Gilbert <dgilbert@interlog.com>
Cc: <stable@vger.kernel.org> # v4.1+
Signed-off-by: default avatarNicholas Bellinger <nab@linux-iscsi.org>
parent 8f9b5654

drivers/target/target_core_xcopy.c

+4 −2
Original line number Diff line number Diff line
@@ -450,6 +450,8 @@ int target_xcopy_setup_pt(void) 
	memset(&xcopy_pt_sess, 0, sizeof(struct se_session));

	INIT_LIST_HEAD(&xcopy_pt_sess.sess_list);

	INIT_LIST_HEAD(&xcopy_pt_sess.sess_acl_list);

	INIT_LIST_HEAD(&xcopy_pt_sess.sess_cmd_list);

	spin_lock_init(&xcopy_pt_sess.sess_cmd_lock);



	xcopy_pt_nacl.se_tpg = &xcopy_pt_tpg;

	xcopy_pt_nacl.nacl_sess = &xcopy_pt_sess;
@@ -644,7 +646,7 @@ static int target_xcopy_read_source( 
	pr_debug("XCOPY: Built READ_16: LBA: %llu Sectors: %u Length: %u\n",

		(unsigned long long)src_lba, src_sectors, length);



	transport_init_se_cmd(se_cmd, &xcopy_pt_tfo, NULL, length,

	transport_init_se_cmd(se_cmd, &xcopy_pt_tfo, &xcopy_pt_sess, length,

			      DMA_FROM_DEVICE, 0, &xpt_cmd->sense_buffer[0]);

	xop->src_pt_cmd = xpt_cmd;
@@ -704,7 +706,7 @@ static int target_xcopy_write_destination( 
	pr_debug("XCOPY: Built WRITE_16: LBA: %llu Sectors: %u Length: %u\n",

		(unsigned long long)dst_lba, dst_sectors, length);



	transport_init_se_cmd(se_cmd, &xcopy_pt_tfo, NULL, length,

	transport_init_se_cmd(se_cmd, &xcopy_pt_tfo, &xcopy_pt_sess, length,

			      DMA_TO_DEVICE, 0, &xpt_cmd->sense_buffer[0]);

	xop->dst_pt_cmd = xpt_cmd;