Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 43d24e48 authored by Vince Bridgers's avatar Vince Bridgers Committed by David S. Miller
Browse files

net: stmmac: Correct duplicate if/then/else case found by cppcheck 



Cppcheck found a duplicate if/then/else case where a receive descriptor
was being processed. This patch corrects that issue.

cppcheck --force --enable=all --inline-suppr .
...
Checking enh_desc.c...
[enh_desc.c:148] -> [enh_desc.c:144]: (style) Found duplicate if expressions.
...

Signed-off-by: default avatarVince Bridgers <vbridgers2013@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 0acf1676

drivers/net/ethernet/stmicro/stmmac/enh_desc.c

+1 −1
Original line number Diff line number Diff line
@@ -145,7 +145,7 @@ static void enh_desc_get_ext_status(void *data, struct stmmac_extra_stats *x, 
			x->rx_msg_type_delay_req++;

		else if (p->des4.erx.msg_type == RDES_EXT_DELAY_RESP)

			x->rx_msg_type_delay_resp++;

		else if (p->des4.erx.msg_type == RDES_EXT_DELAY_REQ)

		else if (p->des4.erx.msg_type == RDES_EXT_PDELAY_REQ)

			x->rx_msg_type_pdelay_req++;

		else if (p->des4.erx.msg_type == RDES_EXT_PDELAY_RESP)

			x->rx_msg_type_pdelay_resp++;