Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 43bdd14a authored by Zack Rusin's avatar Zack Rusin Committed by Greg Kroah-Hartman
Browse files

drm/vmwgfx: Initialize drm_mode_fb_cmd2 



commit 3059d9b9f6aa433a55b9d0d21b566396d5497c33 upstream.

Transition to drm_mode_fb_cmd2 from drm_mode_fb_cmd left the structure
unitialized. drm_mode_fb_cmd2 adds a few additional members, e.g. flags
and modifiers which were never initialized. Garbage in those members
can cause random failures during the bringup of the fbcon.

Initializing the structure fixes random blank screens after bootup due
to flags/modifiers mismatches during the fbcon bring up.

Fixes: dabdcdc9 ("drm/vmwgfx: Switch to mode_cmd2")
Signed-off-by: default avatarZack Rusin <zackr@vmware.com>
Cc: Daniel Vetter <daniel.vetter@intel.com>
Cc: <stable@vger.kernel.org> # v4.10+
Reviewed-by: default avatarMartin Krastev <krastevm@vmware.com>
Reviewed-by: default avatarMaaz Mombasawala <mombasawalam@vmware.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20220302152426.885214-7-zack@kde.org


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 1d1b0383

drivers/gpu/drm/vmwgfx/vmwgfx_fb.c

+1 −1
Original line number Diff line number Diff line
@@ -498,7 +498,7 @@ static int vmw_fb_kms_detach(struct vmw_fb_par *par, 


static int vmw_fb_kms_framebuffer(struct fb_info *info)

{

	struct drm_mode_fb_cmd2 mode_cmd;

	struct drm_mode_fb_cmd2 mode_cmd = {0};

	struct vmw_fb_par *par = info->par;

	struct fb_var_screeninfo *var = &info->var;

	struct drm_framebuffer *cur_fb;