Commit 43a35428 authored Nov 30, 2017 by Takashi Iwai

ALSA: seq: Remove spurious WARN_ON() at timer check



The use of snd_BUG_ON() in ALSA sequencer timer may lead to a spurious
WARN_ON() when a slave timer is deployed as its backend and a
corresponding master timer stops meanwhile.  The symptom was triggered
by syzkaller spontaneously.

Since the NULL timer is valid there, rip off snd_BUG_ON().

Reported-by: syzbot <syzkaller@googlegroups.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Takashi Iwai <tiwai@suse.de>

parent 4fbd8d19

sound/core/seq/seq_timer.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -355,7 +355,7 @@ static int initialize_timer(struct snd_seq_timer *tmr)
		unsigned long freq;

		t = tmr->timeri->timer;
		if (snd_BUG_ON(!t))
		if (!t)
		return -EINVAL;

		freq = tmr->preferred_resolution;