Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 437de041 authored by Coly Li's avatar Coly Li Committed by Greg Kroah-Hartman
Browse files

bcache: fix input overflow to writeback_rate_minimum 



[ Upstream commit dab71b2db98dcdd4657d151b01a7be88ce10f9d1 ]

dc->writeback_rate_minimum is type unsigned integer variable, it is set
via sysfs interface, and converte from input string to unsigned integer
by d_strtoul_nonzero(). When the converted input value is larger than
UINT_MAX, overflow to unsigned integer happens.

This patch fixes the overflow by using sysfs_strotoul_clamp() to
convert input string and limit the value in range [1, UINT_MAX], then
the overflow can be avoided.

Signed-off-by: default avatarColy Li <colyli@suse.de>
Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent be488566

drivers/md/bcache/sysfs.c

+3 −1
Original line number Diff line number Diff line
@@ -289,7 +289,9 @@ STORE(__cached_dev) 
	sysfs_strtoul_clamp(writeback_rate_p_term_inverse,

			    dc->writeback_rate_p_term_inverse,

			    1, UINT_MAX);

	d_strtoul_nonzero(writeback_rate_minimum);

	sysfs_strtoul_clamp(writeback_rate_minimum,

			    dc->writeback_rate_minimum,

			    1, UINT_MAX);



	sysfs_strtoul_clamp(io_error_limit, dc->error_limit, 0, INT_MAX);