Commit 43675ffa authored Nov 04, 2015 by Dan Carpenter Committed by Maxime Ripard Nov 17, 2015

bus: sunxi-rsb: unlock on error in sunxi_rsb_read()



Don't forget to unlock before returning an error code.

Fixes: d787dcdb ('bus: sunxi-rsb: Add driver for Allwinner Reduced Serial Bus')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Chen-Yu Tsai <wens@csie.org>
Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>

parent c65d2359

drivers/bus/sunxi-rsb.c

+2 −2

Original line number	Original line	Diff line number	Diff line
	@@ -342,13 +342,13 @@ static int sunxi_rsb_read(struct sunxi_rsb *rsb, u8 rtaddr, u8 addr,

	ret = _sunxi_rsb_run_xfer(rsb);		ret = _sunxi_rsb_run_xfer(rsb);
	if (ret)		if (ret)
	goto out;		goto unlock;

	*buf = readl(rsb->regs + RSB_DATA);		*buf = readl(rsb->regs + RSB_DATA);

			unlock:
	mutex_unlock(&rsb->lock);		mutex_unlock(&rsb->lock);

	out:
	return ret;		return ret;
	}		}