Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 42a2b6ad authored by Eric Sandeen's avatar Eric Sandeen Committed by Linus Torvalds
Browse files

ext3: fix setup_new_group_blocks locking 



setup_new_group_blocks() manipulates the group descriptor block bh under
the block_bitmap bh's lock.  It shouldn't matter since nobody but resize
should be touching these blocks, but it's worth fixing up.

Signed-off-by: default avatarEric Sandeen <sandeen@redhat.com>
C: <linux-ext4@vger.kernel.org>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 0f0a89eb

fs/ext3/resize.c

+3 −3
Original line number Diff line number Diff line
@@ -245,10 +245,10 @@ static int setup_new_group_blocks(struct super_block *sb, 
			brelse(gdb);

			goto exit_bh;

		}

		lock_buffer(bh);

		memcpy(gdb->b_data, sbi->s_group_desc[i]->b_data, bh->b_size);

		lock_buffer(gdb);

		memcpy(gdb->b_data, sbi->s_group_desc[i]->b_data, gdb->b_size);

		set_buffer_uptodate(gdb);

		unlock_buffer(bh);

		unlock_buffer(gdb);

		ext3_journal_dirty_metadata(handle, gdb);

		ext3_set_bit(bit, bh->b_data);

		brelse(gdb);