Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 426a0f0b authored by Brian Norris's avatar Brian Norris Committed by Kalle Valo
Browse files

ath10k: snoc: use correct bus-specific pointer in RX retry 



We're 'ath10k_snoc', not 'ath10k_pci'. This probably means we're
accessing junk data in ath10k_snoc_rx_replenish_retry(), unless
'ath10k_snoc' and 'ath10k_pci' happen to have very similar struct
layouts.

Noticed by inspection.

Fixes: d9151052 ("ath10k: add hif rx methods for wcn3990")
Signed-off-by: default avatarBrian Norris <briannorris@chromium.org>
Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
parent 0644fef9

drivers/net/wireless/ath/ath10k/snoc.c

+1 −1
Original line number Original line Diff line number Diff line
@@ -449,7 +449,7 @@ static void ath10k_snoc_htt_rx_cb(struct ath10k_ce_pipe *ce_state) 




static void ath10k_snoc_rx_replenish_retry(struct timer_list *t)

static void ath10k_snoc_rx_replenish_retry(struct timer_list *t)

{

{

	struct ath10k_pci *ar_snoc = from_timer(ar_snoc, t, rx_post_retry);

	struct ath10k_snoc *ar_snoc = from_timer(ar_snoc, t, rx_post_retry);

	struct ath10k *ar = ar_snoc->ar;

	struct ath10k *ar = ar_snoc->ar;





	ath10k_snoc_rx_post(ar);

	ath10k_snoc_rx_post(ar);