Commit 4264cb64 authored Apr 17, 2014 by H Hartley Sweeten Committed by Greg Kroah-Hartman Apr 22, 2014

staging: comedi: gsc_hpdi: validate the cmd->start_arg



The cmd->start_arg should be trivially validated in Step 3 of the
(*do_cmdtest) functions. Add the necessary code.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent bdbca9b5

drivers/staging/comedi/drivers/gsc_hpdi.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -410,6 +410,8 @@ static int gsc_hpdi_cmd_test(struct comedi_device *dev,

		/* Step 3: check if arguments are trivially valid */

		err \|= cfc_check_trigger_arg_is(&cmd->start_arg, 0);

		if (!cmd->chanlist_len \|\| !cmd->chanlist) {
		cmd->chanlist_len = 32;
		err \|= -EINVAL;