Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 423b4487 authored by Sagi Grimberg's avatar Sagi Grimberg Committed by Christoph Hellwig
Browse files

nvmet: release a ns reference in nvmet_req_uninit if needed 



nvmet_req_init looked up a namespace and took a reference on it (unless it
failed prior to that). If the request is uninitialized (in error cases) we
need to remove that reference in case it was taken, otherwise we leak
namespace reference when calling nvme_req_uninit.

Signed-off-by: default avatarSagi Grimberg <sagi@grimberg.me>
Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
parent df351ef7

drivers/nvme/target/core.c

+3 −0
Original line number Diff line number Diff line
@@ -512,6 +512,7 @@ bool nvmet_req_init(struct nvmet_req *req, struct nvmet_cq *cq, 
	req->sg_cnt = 0;

	req->transfer_len = 0;

	req->rsp->status = 0;

	req->ns = NULL;



	/* no support for fused commands yet */

	if (unlikely(flags & (NVME_CMD_FUSE_FIRST | NVME_CMD_FUSE_SECOND))) {
@@ -557,6 +558,8 @@ EXPORT_SYMBOL_GPL(nvmet_req_init); 
void nvmet_req_uninit(struct nvmet_req *req)

{

	percpu_ref_put(&req->sq->ref);

	if (req->ns)

		nvmet_put_namespace(req->ns);

}

EXPORT_SYMBOL_GPL(nvmet_req_uninit);