Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 42020c70 authored by Bjorn Andersson's avatar Bjorn Andersson Committed by Kishon Vijay Abraham I
Browse files

phy: qcom-ufs: Suppress extraneous logging 



The error paths of the common qcom-ufs functions for registering the
phy, acquiring clocks and acquiring regulators all print specific error
messages before returning an error, so there is no value in printing yet
another - more generic - message when this occur.

Reviewed-by: default avatarVivek Gautam <vivek.gautam@codeaurora.org>
Reviewed-by: default avatarSubhash Jadavani <subhashj@codeaurora.org>
Signed-off-by: default avatarBjorn Andersson <bjorn.andersson@linaro.org>
Signed-off-by: default avatarKishon Vijay Abraham I <kishon@ti.com>
parent 96c163f1

drivers/phy/phy-qcom-ufs-qmp-14nm.c

+3 −12
Original line number Diff line number Diff line
@@ -132,27 +132,18 @@ static int ufs_qcom_phy_qmp_14nm_probe(struct platform_device *pdev) 
				&ufs_qcom_phy_qmp_14nm_phy_ops, &phy_14nm_ops);



	if (!generic_phy) {

		dev_err(dev, "%s: ufs_qcom_phy_generic_probe() failed\n",

			__func__);

		err = -EIO;

		goto out;

	}



	err = ufs_qcom_phy_init_clks(phy_common);

	if (err) {

		dev_err(phy_common->dev,

			"%s: ufs_qcom_phy_init_clks() failed %d\n",

			__func__, err);

	if (err)

		goto out;

	}



	err = ufs_qcom_phy_init_vregulators(phy_common);

	if (err) {

		dev_err(phy_common->dev,

			"%s: ufs_qcom_phy_init_vregulators() failed %d\n",

			__func__, err);

	if (err)

		goto out;

	}



	phy_common->vdda_phy.max_uV = UFS_PHY_VDDA_PHY_UV;

	phy_common->vdda_phy.min_uV = UFS_PHY_VDDA_PHY_UV;

drivers/phy/phy-qcom-ufs-qmp-20nm.c

+2 −10
Original line number Diff line number Diff line
@@ -190,25 +190,17 @@ static int ufs_qcom_phy_qmp_20nm_probe(struct platform_device *pdev) 
				&ufs_qcom_phy_qmp_20nm_phy_ops, &phy_20nm_ops);



	if (!generic_phy) {

		dev_err(dev, "%s: ufs_qcom_phy_generic_probe() failed\n",

			__func__);

		err = -EIO;

		goto out;

	}



	err = ufs_qcom_phy_init_clks(phy_common);

	if (err) {

		dev_err(phy_common->dev, "%s: ufs_qcom_phy_init_clks() failed %d\n",

			__func__, err);

	if (err)

		goto out;

	}



	err = ufs_qcom_phy_init_vregulators(phy_common);

	if (err) {

		dev_err(phy_common->dev, "%s: ufs_qcom_phy_init_vregulators() failed %d\n",

			__func__, err);

	if (err)

		goto out;

	}



	ufs_qcom_phy_qmp_20nm_advertise_quirks(phy_common);