Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 41f632fe authored by Johan Hovold's avatar Johan Hovold Committed by Linus Walleij
Browse files

pinctrl: lantiq: remove bogus of_gpio_chip_add 



Remove bogus call to of_gpiochip_add (and of_gpio_chip remove in error
path) which is also called when adding the gpio chip.

This prevents adding the same pinctrl range twice.

Fixes: 3f8c50c9 ("OF: pinctrl: MIPS: lantiq: implement lantiq/xway
pinctrl support")

Signed-off-by: default avatarJohan Hovold <johan@kernel.org>
Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent db93facf

drivers/pinctrl/pinctrl-xway.c

+0 −2
Original line number Original line Diff line number Diff line
@@ -798,10 +798,8 @@ static int pinmux_xway_probe(struct platform_device *pdev) 




	/* load the gpio chip */

	/* load the gpio chip */

	xway_chip.dev = &pdev->dev;

	xway_chip.dev = &pdev->dev;

	of_gpiochip_add(&xway_chip);

	ret = gpiochip_add(&xway_chip);

	ret = gpiochip_add(&xway_chip);

	if (ret) {

	if (ret) {

		of_gpiochip_remove(&xway_chip);

		dev_err(&pdev->dev, "Failed to register gpio chip\n");

		dev_err(&pdev->dev, "Failed to register gpio chip\n");

		return ret;

		return ret;

	}

	}