Commit 41df7f6d authored Sep 11, 2013 by Kees Cook Committed by Jiri Kosina Sep 13, 2013

HID: steelseries: validate output report details



A HID device could send a malicious output report that would cause the
steelseries HID driver to write beyond the output report allocation
during initialization, causing a heap overflow:

[  167.981534] usb 1-1: New USB device found, idVendor=1038, idProduct=1410
...
[  182.050547] BUG kmalloc-256 (Tainted: G        W   ): Redzone overwritten

CVE-2013-2891

Signed-off-by: Kees Cook <keescook@chromium.org>
Cc: stable@vger.kernel.org
Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>

parent 9446edb9

drivers/hid/hid-steelseries.c

+5 −0

Original line number	Diff line number	Diff line
		@@ -249,6 +249,11 @@ static int steelseries_srws1_probe(struct hid_device *hdev,
		goto err_free;
		}

		if (!hid_validate_values(hdev, HID_OUTPUT_REPORT, 0, 0, 16)) {
		ret = -ENODEV;
		goto err_free;
		}

		ret = hid_hw_start(hdev, HID_CONNECT_DEFAULT);
		if (ret) {
		hid_err(hdev, "hw start failed\n");