Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 41c23958 authored by Johan Hovold's avatar Johan Hovold Committed by Greg Kroah-Hartman
Browse files

greybus: camera: destroy data connection on link-config errors 



Make sure to tear down the data connection also on failure to configure
the link by setting the data_connected flag immediately after creating
the connection.

Signed-off-by: default avatarJohan Hovold <johan@hovoldconsulting.com>
Reviewed-by: default avatarLaurent Pinchart <laurent.pinchart@linaro.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@google.com>
parent b9f71bc8

drivers/staging/greybus/camera.c

+2 −2
Original line number Diff line number Diff line
@@ -604,6 +604,8 @@ static int gb_camera_connection_init(struct gb_connection *connection) 
	if (ret < 0)

		goto error;



	gcam->data_connected = true;



	ret = gb_svc_link_config(svc, connection->intf->interface_id,

				 GB_SVC_LINK_CONFIG_BURST_HS_A, 2, 2, 0);

	if (ret < 0)
@@ -614,8 +616,6 @@ static int gb_camera_connection_init(struct gb_connection *connection) 
	if (ret < 0)

		goto error;



	gcam->data_connected = true;



	ret = gb_camera_debugfs_init(gcam);

	if (ret < 0)

		goto error;