Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 40fa3644 authored by Taehee Yoo's avatar Taehee Yoo Committed by Greg Kroah-Hartman
Browse files

hsr: use netdev_err() instead of WARN_ONCE() 



commit 4b793acdca0050739b99ace6a8b9e7f717f57c6b upstream.

When HSR interface is sending a frame, it finds a node with
the destination ethernet address from the list.
If there is no node, it calls WARN_ONCE().
But, using WARN_ONCE() for this situation is a little bit overdoing.
So, in this patch, the netdev_err() is used instead.

Signed-off-by: default avatarTaehee Yoo <ap420073@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
Cc: George Kennedy <george.kennedy@oracle.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 75e26178

net/hsr/hsr_framereg.c

+2 −1
Original line number Original line Diff line number Diff line
@@ -310,7 +310,8 @@ void hsr_addr_subst_dest(struct hsr_node *node_src, struct sk_buff *skb, 




	node_dst = find_node_by_AddrA(&port->hsr->node_db, eth_hdr(skb)->h_dest);

	node_dst = find_node_by_AddrA(&port->hsr->node_db, eth_hdr(skb)->h_dest);

	if (!node_dst) {

	if (!node_dst) {

		WARN_ONCE(1, "%s: Unknown node\n", __func__);

		if (net_ratelimit())

			netdev_err(skb->dev, "%s: Unknown node\n", __func__);

		return;

		return;

	}

	}

	if (port->type != node_dst->AddrB_port)

	if (port->type != node_dst->AddrB_port)