Commit 40a2945b authored Apr 06, 2009 by Mike Frysinger Committed by Linus Torvalds Apr 07, 2009

Blackfin SPI Driver: do not check for SPI errors if DMA itself did not flag any



We only need to check SPI error when DMA failes, cause that is the DMA IRQ
handling routine.

Signed-off-by: Mike Frysinger <vapier.adi@gmail.com>
Signed-off-by: Bryan Wu <cooloney@kernel.org>
Cc: David Brownell <david-b@pacbell.net>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent d24bd1d0

drivers/spi/spi_bfin5xx.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -587,7 +587,7 @@ static irqreturn_t dma_irq_handler(int irq, void *dev_id)
		while (!(read_STAT(drv_data) & SPIF))
		cpu_relax();

		if (spistat & RBSY) {
		if ((dmastat & DMA_ERR) && (spistat & RBSY)) {
		msg->state = ERROR_STATE;
		dev_err(&drv_data->pdev->dev, "dma receive: fifo/buffer overflow\n");
		} else {