Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 404123c2 authored by Michael S. Tsirkin's avatar Michael S. Tsirkin
Browse files

virtio: allow drivers to validate features 



Some drivers can't support all features in all configurations.  At the
moment we blindly set FEATURES_OK and later FAILED.  Support this better
by adding a callback drivers can use to do some early checks.

Signed-off-by: default avatarMichael S. Tsirkin <mst@redhat.com>
parent 2e123b44

drivers/virtio/virtio.c

+6 −0
Original line number Diff line number Diff line
@@ -232,6 +232,12 @@ static int virtio_dev_probe(struct device *_d) 
		if (device_features & (1ULL << i))

			__virtio_set_bit(dev, i);



	if (drv->validate) {

		err = drv->validate(dev);

		if (err)

			goto err;

	}



	err = virtio_finalize_features(dev);

	if (err)

		goto err;

include/linux/virtio.h

+1 −0
Original line number Diff line number Diff line
@@ -167,6 +167,7 @@ struct virtio_driver { 
	unsigned int feature_table_size;

	const unsigned int *feature_table_legacy;

	unsigned int feature_table_size_legacy;

	int (*validate)(struct virtio_device *dev);

	int (*probe)(struct virtio_device *dev);

	void (*scan)(struct virtio_device *dev);

	void (*remove)(struct virtio_device *dev);