Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 403f0727 authored by Tobias Klauser's avatar Tobias Klauser Committed by David S. Miller
Browse files

vlan: Remove unnecessary comparison of unsigned against 0 



args.u.name_type is of type unsigned int and is always >= 0.

This fixes the following GCC warning:

  net/8021q/vlan.c: In function ‘vlan_ioctl_handler’:
  net/8021q/vlan.c:574:14: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]

Signed-off-by: default avatarTobias Klauser <tklauser@distanz.ch>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 3f3177bb

net/8021q/vlan.c

+1 −2
Original line number Diff line number Diff line
@@ -571,8 +571,7 @@ static int vlan_ioctl_handler(struct net *net, void __user *arg) 
		err = -EPERM;

		if (!ns_capable(net->user_ns, CAP_NET_ADMIN))

			break;

		if ((args.u.name_type >= 0) &&

		    (args.u.name_type < VLAN_NAME_TYPE_HIGHEST)) {

		if (args.u.name_type < VLAN_NAME_TYPE_HIGHEST) {

			struct vlan_net *vn;



			vn = net_generic(net, vlan_net_id);