Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 403ed278 authored by Alessio Igor Bogani's avatar Alessio Igor Bogani Committed by Rusty Russell
Browse files

module: Use the binary search for symbols resolution 



Takes advantage of the order and locates symbols using binary search.

This work was supported by a hardware donation from the CE Linux Forum.

Signed-off-by: default avatarAlessio Igor Bogani <abogani@kernel.org>
Signed-off-by: default avatarRusty Russell <rusty@rustcorp.com.au>
Tested-by: default avatarDirk Behme <dirk.behme@googlemail.com>
parent 1a94dc35

kernel/module.c

+16 −5
Original line number Diff line number Diff line
@@ -57,6 +57,7 @@ 
#include <linux/kmemleak.h>

#include <linux/jump_label.h>

#include <linux/pfn.h>

#include <linux/bsearch.h>



#define CREATE_TRACE_POINTS

#include <trace/events/module.h>
@@ -363,17 +364,27 @@ static bool check_symbol(const struct symsearch *syms, 
	return true;

}



static int cmp_name(const void *va, const void *vb)

{

	const char *a;

	const struct kernel_symbol *b;

	a = va; b = vb;

	return strcmp(a, b->name);

}



static bool find_symbol_in_section(const struct symsearch *syms,

				   struct module *owner,

				   void *data)

{

	struct find_symbol_arg *fsa = data;

	unsigned int i;

	struct kernel_symbol *sym;



	sym = bsearch(fsa->name, syms->start, syms->stop - syms->start,

			sizeof(struct kernel_symbol), cmp_name);



	if (sym != NULL && check_symbol(syms, owner, sym - syms->start, data))

		return true;



	for (i = 0; i < syms->stop - syms->start; i++) {

		if (strcmp(syms->start[i].name, fsa->name) == 0)

			return check_symbol(syms, owner, i, data);

	}

	return false;

}