Commit 3ff861f5 authored Mar 01, 2017 by Dmitry Torokhov Committed by Jonathan Cameron Mar 05, 2017

iio: magnetometer: ak8974: remove incorrect __exit markups



Even if bus is not hot-pluggable, devices can be unbound from the
driver via sysfs, so we should not be using __exit annotations on
remove() methods. The only exception is drivers registered with
platform_driver_probe() which specifically disables sysfs bind/unbind
attributes.

Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Cc: <stable@vger.kernel.org>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>

parent 3bec2474

drivers/iio/magnetometer/ak8974.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -763,7 +763,7 @@ static int ak8974_probe(struct i2c_client *i2c,
		return ret;
		}

		static int __exit ak8974_remove(struct i2c_client *i2c)
		static int ak8974_remove(struct i2c_client *i2c)
		{
		struct iio_dev *indio_dev = i2c_get_clientdata(i2c);
		struct ak8974 *ak8974 = iio_priv(indio_dev);
		@@ -845,7 +845,7 @@ static struct i2c_driver ak8974_driver = {
		.of_match_table = of_match_ptr(ak8974_of_match),
		},
		.probe = ak8974_probe,
		.remove = __exit_p(ak8974_remove),
		.remove = ak8974_remove,
		.id_table = ak8974_id,
		};
		module_i2c_driver(ak8974_driver);