Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3fce3fb0 authored Jul 08, 2008 by David Howells Committed by Mauro Carvalho Chehab Jul 20, 2008

V4L/DVB (8249): Fix pointer cast warnings in the ivtv framebuffer driver



Fix casts of pointers to integers of different sizes in the ivtv framebuffer
driver.

These were introduced in patch 38eb6ba5b8487d15b020fe391d324edd2b659b03.

Signed-off-by: David Howells <dhowells@redhat.com>
Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>

parent 5a367dfb

drivers/media/video/ivtv/ivtvfb.c

+4 −3

Original line number	Diff line number	Diff line
		@@ -417,10 +417,11 @@ static ssize_t ivtvfb_write(struct fb_info info, const char __user buf,
		if (!err) {
		/* If transfer size > threshold and both src/dst
		addresses are aligned, use DMA */
		if (count >= 4096 && ((u32)buf & 3) == ((u32)dst & 3)) {
		if (count >= 4096 &&
		((unsigned long)buf & 3) == ((unsigned long)dst & 3)) {
		/* Odd address = can't DMA. Align */
		if ((u32)dst & 3) {
		lead = 4 - ((u32)dst & 3);
		if ((unsigned long)dst & 3) {
		lead = 4 - ((unsigned long)dst & 3);
		memcpy(dst, buf, lead);
		buf += lead;
		dst += lead;