Commit 3f7a46c6 authored Oct 07, 2013 by Nicholas Bellinger

target: Allow non zero ListID in EXTENDED_COPY parameter list



This patch changes target_do_xcopy() to allow processing of non-zero
ListIDs in EXTENDED_COPY parameter list data, instead of returning
CHECK_CONDITION status.

As the copy offload implementation reports SNLID=1 (Supports No ListID)
in OPERATING PARAMETERS, any ListID value presented by the client is
currently ignored.

Also, properly extract list_id_usage for informational purposes.

Reported-by: Thomas Glanzmann <thomas@glanzmann.de>
Reported-by: Douglas Gilbert <dgilbert@interlog.com>
Cc: Hannes Reinecke <hare@suse.de>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>

parent 934a138e

drivers/target/target_core_xcopy.c

+2 −5

Original line number	Diff line number	Diff line
		@@ -911,11 +911,8 @@ sense_reason_t target_do_xcopy(struct se_cmd *se_cmd)
		}

		list_id = p[0];
		if (list_id != 0x00) {
		pr_err("XCOPY with non zero list_id: 0x%02x\n", list_id);
		goto out;
		}
		list_id_usage = (p[1] & 0x18);
		list_id_usage = (p[1] & 0x18) >> 3;

		/*
		* Determine TARGET DESCRIPTOR LIST LENGTH + SEGMENT DESCRIPTOR LIST LENGTH
		*/