Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3f557202 authored by Andrey Utkin's avatar Andrey Utkin Committed by John W. Linville
Browse files

ath9k: drop negativity checks for unsigned values coming from kstrtoul() 

Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=80471
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=80481


Reported-by: default avatarDavid Binderman <dcb314@hotmail.com>
Signed-off-by: default avatarAndrey Utkin <andrey.krieger.utkin@gmail.com>
Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
parent 3ae351ab

drivers/net/wireless/ath/ath9k/debug.c

+1 −1
Original line number Diff line number Diff line
@@ -202,7 +202,7 @@ static ssize_t write_file_ani(struct file *file, 
	if (kstrtoul(buf, 0, &ani))

		return -EINVAL;



	if (ani < 0 || ani > 1)

	if (ani > 1)

		return -EINVAL;



	common->disable_ani = !ani;

drivers/net/wireless/ath/ath9k/spectral.c

+4 −4
Original line number Diff line number Diff line
@@ -313,7 +313,7 @@ static ssize_t write_file_spectral_short_repeat(struct file *file, 
	if (kstrtoul(buf, 0, &val))

		return -EINVAL;



	if (val < 0 || val > 1)

	if (val > 1)

		return -EINVAL;



	sc->spec_config.short_repeat = val;
@@ -361,7 +361,7 @@ static ssize_t write_file_spectral_count(struct file *file, 
	if (kstrtoul(buf, 0, &val))

		return -EINVAL;



	if (val < 0 || val > 255)

	if (val > 255)

		return -EINVAL;



	sc->spec_config.count = val;
@@ -409,7 +409,7 @@ static ssize_t write_file_spectral_period(struct file *file, 
	if (kstrtoul(buf, 0, &val))

		return -EINVAL;



	if (val < 0 || val > 255)

	if (val > 255)

		return -EINVAL;



	sc->spec_config.period = val;
@@ -457,7 +457,7 @@ static ssize_t write_file_spectral_fft_period(struct file *file, 
	if (kstrtoul(buf, 0, &val))

		return -EINVAL;



	if (val < 0 || val > 15)

	if (val > 15)

		return -EINVAL;



	sc->spec_config.fft_period = val;