Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3f47da0f authored by Lai Jiangshan's avatar Lai Jiangshan Committed by Paul E. McKenney
Browse files

rcu_tree: Avoid touching rnp->completed when a new GP is started 



In rcu_gp_init(), rnp->completed equals to rsp->completed in THEORY,
we don't need to touch it normally.  If something goes wrong,
it will complain and fixup rnp->completed and avoid oops.
This commit thus avoids the normal needless store to rnp->completed.

Signed-off-by: default avatarLai Jiangshan <laijs@cn.fujitsu.com>
Signed-off-by: default avatarPaul E. McKenney <paulmck@linux.vnet.ibm.com>
parent ee376dbd

kernel/rcu/tree.c

+2 −2
Original line number Diff line number Diff line
@@ -1757,7 +1757,7 @@ static int rcu_gp_init(struct rcu_state *rsp) 
		rcu_preempt_check_blocked_tasks(rnp);

		rnp->qsmask = rnp->qsmaskinit;

		ACCESS_ONCE(rnp->gpnum) = rsp->gpnum;

		WARN_ON_ONCE(rnp->completed != rsp->completed);

		if (WARN_ON_ONCE(rnp->completed != rsp->completed))

			ACCESS_ONCE(rnp->completed) = rsp->completed;

		if (rnp == rdp->mynode)

			(void)__note_gp_changes(rsp, rnp, rdp);