Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3ef0279b authored by Sagi Grimberg's avatar Sagi Grimberg Committed by Christoph Hellwig
Browse files

nvme-rdma: Check remotely invalidated rkey matches our expected rkey 



If we got a remote invalidation on a bogus rkey, this is a protocol error.
Fail the connection in this case.

Signed-off-by: default avatarSagi Grimberg <sagi@grimberg.me>
Reviewed-by: default avatarMax Gurtovoy <maxg@mellanox.com>
Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
parent 2f122e4f

drivers/nvme/host/rdma.c

+7 −2
Original line number Diff line number Diff line
@@ -1334,8 +1334,13 @@ static int nvme_rdma_process_nvme_rsp(struct nvme_rdma_queue *queue, 
	req->status = cqe->status;

	req->result = cqe->result;



	if ((wc->wc_flags & IB_WC_WITH_INVALIDATE) &&

	    wc->ex.invalidate_rkey == req->mr->rkey) {

	if (wc->wc_flags & IB_WC_WITH_INVALIDATE) {

		if (unlikely(wc->ex.invalidate_rkey != req->mr->rkey)) {

			dev_err(queue->ctrl->ctrl.device,

				"Bogus remote invalidation for rkey %#x\n",

				req->mr->rkey);

			nvme_rdma_error_recovery(queue->ctrl);

		}

		req->mr->need_inval = false;

	} else if (req->mr->need_inval) {

		ret = nvme_rdma_inv_rkey(queue, req);