Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3eec6a1c authored by Dmitry Torokhov's avatar Dmitry Torokhov Committed by Greg Kroah-Hartman
Browse files

firmware: vpd: use kdtrndup when copying section key 



Instead of open-coding kstrndup with kzalloc + memcpy, let's use
the helper.

Signed-off-by: default avatarDmitry Torokhov <dmitry.torokhov@gmail.com>
Reviewed-by: default avatarGuenter Roeck <groeck@chromium.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 40fbb238

drivers/firmware/google/vpd.c

+2 −3
Original line number Diff line number Diff line
@@ -118,14 +118,13 @@ static int vpd_section_attrib_add(const u8 *key, s32 key_len, 
	info = kzalloc(sizeof(*info), GFP_KERNEL);

	if (!info)

		return -ENOMEM;

	info->key = kzalloc(key_len + 1, GFP_KERNEL);



	info->key = kstrndup(key, key_len, GFP_KERNEL);

	if (!info->key) {

		ret = -ENOMEM;

		goto free_info;

	}



	memcpy(info->key, key, key_len);



	sysfs_bin_attr_init(&info->bin_attr);

	info->bin_attr.attr.name = info->key;

	info->bin_attr.attr.mode = 0444;