Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3ee94018 authored by Guo-Fu Tseng's avatar Guo-Fu Tseng Committed by David S. Miller
Browse files

jme: Add comment in jme_set_settings 



Explains what `fdc` variable is for.

Signed-off-by: default avatarGuo-Fu Tseng <cooldavid@cooldavid.org>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent c8a8684d

drivers/net/jme.c

+6 −3
Original line number Original line Diff line number Diff line
@@ -2394,6 +2394,10 @@ jme_set_settings(struct net_device *netdev, 
	if (ecmd->speed == SPEED_1000 && ecmd->autoneg != AUTONEG_ENABLE)

	if (ecmd->speed == SPEED_1000 && ecmd->autoneg != AUTONEG_ENABLE)

		return -EINVAL;

		return -EINVAL;





	/*

	 * Check If user changed duplex only while force_media.

	 * Hardware would not generate link change interrupt.

	 */

	if (jme->mii_if.force_media &&

	if (jme->mii_if.force_media &&

	ecmd->autoneg != AUTONEG_ENABLE &&

	ecmd->autoneg != AUTONEG_ENABLE &&

	(jme->mii_if.full_duplex != ecmd->duplex))

	(jme->mii_if.full_duplex != ecmd->duplex))
@@ -2403,10 +2407,9 @@ jme_set_settings(struct net_device *netdev, 
	rc = mii_ethtool_sset(&(jme->mii_if), ecmd);

	rc = mii_ethtool_sset(&(jme->mii_if), ecmd);

	spin_unlock_bh(&jme->phy_lock);

	spin_unlock_bh(&jme->phy_lock);





	if (!rc && fdc)

		jme_reset_link(jme);



	if (!rc) {

	if (!rc) {

		if (fdc)

			jme_reset_link(jme);

		set_bit(JME_FLAG_SSET, &jme->flags);

		set_bit(JME_FLAG_SSET, &jme->flags);

		jme->old_ecmd = *ecmd;

		jme->old_ecmd = *ecmd;

	}

	}