Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3e6eeafc authored by Jingoo Han's avatar Jingoo Han Committed by Linus Walleij
Browse files

pinctrl: sirf: remove unnecessary platform_set_drvdata() 



The driver core clears the driver data to NULL after device_release
or on probe failure, since commit 0998d063
(device-core: Ensure drvdata = NULL when no driver is bound).
Thus, it is not needed to manually clear the device driver data to NULL.

Signed-off-by: default avatarJingoo Han <jg1.han@samsung.com>
Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent 59eb14dc

drivers/pinctrl/pinctrl-sirf.c

+1 −4
Original line number Diff line number Diff line
@@ -1280,9 +1280,8 @@ static int sirfsoc_pinmux_probe(struct platform_device *pdev) 


	spmx->gpio_virtbase = of_iomap(np, 0);

	if (!spmx->gpio_virtbase) {

		ret = -ENOMEM;

		dev_err(&pdev->dev, "can't map gpio registers\n");

		goto out_no_gpio_remap;

		return -ENOMEM;

	}



	spmx->rsc_virtbase = sirfsoc_rsc_of_iomap();
@@ -1316,8 +1315,6 @@ static int sirfsoc_pinmux_probe(struct platform_device *pdev) 
	iounmap(spmx->rsc_virtbase);

out_no_rsc_remap:

	iounmap(spmx->gpio_virtbase);

out_no_gpio_remap:

	platform_set_drvdata(pdev, NULL);

	return ret;

}