Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3e51e3ed authored May 11, 2011 by Samir Bellabes Committed by Ingo Molnar May 12, 2011

sched: Remove unused parameters from sched_fork() and wake_up_new_task()



sched_fork() and wake_up_new_task() are defined with a parameter
'unsigned long clone_flags', which is unused.

This patch removes the parameters.

Signed-off-by: Samir Bellabes <sam@synack.fr>
Acked-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/1305130685-1047-1-git-send-email-sam@synack.fr


Signed-off-by: Ingo Molnar <mingo@elte.hu>

parent 9cb5baba

include/linux/sched.h

+2 −3

Original line number	Original line	Diff line number	Diff line
	@@ -2051,14 +2051,13 @@ extern void xtime_update(unsigned long ticks);

	extern int wake_up_state(struct task_struct *tsk, unsigned int state);		extern int wake_up_state(struct task_struct *tsk, unsigned int state);
	extern int wake_up_process(struct task_struct *tsk);		extern int wake_up_process(struct task_struct *tsk);
	extern void wake_up_new_task(struct task_struct *tsk,		extern void wake_up_new_task(struct task_struct *tsk);
	unsigned long clone_flags);
	#ifdef CONFIG_SMP		#ifdef CONFIG_SMP
	extern void kick_process(struct task_struct *tsk);		extern void kick_process(struct task_struct *tsk);
	#else		#else
	static inline void kick_process(struct task_struct *tsk) { }		static inline void kick_process(struct task_struct *tsk) { }
	#endif		#endif
	extern void sched_fork(struct task_struct *p, int clone_flags);		extern void sched_fork(struct task_struct *p);
	extern void sched_dead(struct task_struct *p);		extern void sched_dead(struct task_struct *p);

	extern void proc_caches_init(void);		extern void proc_caches_init(void);

kernel/fork.c

+2 −2

Original line number	Original line	Diff line number	Diff line
	@@ -1152,7 +1152,7 @@ static struct task_struct *copy_process(unsigned long clone_flags,
	#endif		#endif

	/* Perform scheduler related setup. Assign this task to a CPU. */		/* Perform scheduler related setup. Assign this task to a CPU. */
	sched_fork(p, clone_flags);		sched_fork(p);

	retval = perf_event_init_task(p);		retval = perf_event_init_task(p);
	if (retval)		if (retval)
	@@ -1463,7 +1463,7 @@ long do_fork(unsigned long clone_flags,
	*/		*/
	p->flags &= ~PF_STARTING;		p->flags &= ~PF_STARTING;

	wake_up_new_task(p, clone_flags);		wake_up_new_task(p);

	tracehook_report_clone_complete(trace, regs,		tracehook_report_clone_complete(trace, regs,
	clone_flags, nr, p);		clone_flags, nr, p);

kernel/sched.c

+2 −2

Original line number	Original line	Diff line number	Diff line
	@@ -2741,7 +2741,7 @@ static void __sched_fork(struct task_struct *p)
	/*		/*
	* fork()/clone()-time setup:		* fork()/clone()-time setup:
	*/		*/
	void sched_fork(struct task_struct *p, int clone_flags)		void sched_fork(struct task_struct *p)
	{		{
	unsigned long flags;		unsigned long flags;
	int cpu = get_cpu();		int cpu = get_cpu();
	@@ -2823,7 +2823,7 @@ void sched_fork(struct task_struct *p, int clone_flags)
	* that must be done for every newly created context, then puts the task		* that must be done for every newly created context, then puts the task
	* on the runqueue and wakes it.		* on the runqueue and wakes it.
	*/		*/
	void wake_up_new_task(struct task_struct *p, unsigned long clone_flags)		void wake_up_new_task(struct task_struct *p)
	{		{
	unsigned long flags;		unsigned long flags;
	struct rq *rq;		struct rq *rq;