Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3e434a86 authored by Jarkko Nikula's avatar Jarkko Nikula Committed by Felipe Balbi
Browse files

usb: ehci-omap: Show fatal probing time errors to end user 



There are a few error paths in ehci_hcd_omap_probe that can be triggered
because of memory allocation or hw failure. Change those dev_dbg error
prints to dev_err with an error code printed so that the end users are able
to notice the issue.

Signed-off-by: default avatarJarkko Nikula <jhnikula@gmail.com>
Signed-off-by: default avatarFelipe Balbi <balbi@ti.com>
parent 5f5761cb

drivers/usb/host/ehci-omap.c

+3 −3
Original line number Diff line number Diff line
@@ -796,7 +796,7 @@ static int ehci_hcd_omap_probe(struct platform_device *pdev) 
	hcd = usb_create_hcd(&ehci_omap_hc_driver, &pdev->dev,

			dev_name(&pdev->dev));

	if (!hcd) {

		dev_dbg(&pdev->dev, "failed to create hcd with err %d\n", ret);

		dev_err(&pdev->dev, "failed to create hcd with err %d\n", ret);

		ret = -ENOMEM;

		goto err_create_hcd;

	}
@@ -864,7 +864,7 @@ static int ehci_hcd_omap_probe(struct platform_device *pdev) 


	ret = omap_start_ehc(omap, hcd);

	if (ret) {

		dev_dbg(&pdev->dev, "failed to start ehci\n");

		dev_err(&pdev->dev, "failed to start ehci with err %d\n", ret);

		goto err_start;

	}
@@ -879,7 +879,7 @@ static int ehci_hcd_omap_probe(struct platform_device *pdev) 


	ret = usb_add_hcd(hcd, irq, IRQF_DISABLED | IRQF_SHARED);

	if (ret) {

		dev_dbg(&pdev->dev, "failed to add hcd with err %d\n", ret);

		dev_err(&pdev->dev, "failed to add hcd with err %d\n", ret);

		goto err_add_hcd;

	}