Commit 3e3d8aa6 authored Jun 21, 2017 by Colin Ian King Committed by Kalle Valo Jun 28, 2017

qtnfmac: fix uninitialized return code in ret



The return value ret is unitialized and garbage is being returned
for the three different error conditions when setting up the PCIe
BARs. Fix this by initializing ret to  -ENOMEM to indicate that
the BARs failed to be setup correctly.

Detected by CoverityScan, CID#1437563 ("Unitialized scalar variable")

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Sergey Matyukevich <sergey.matyukevich.os@quantenna.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>

parent b90a1685

drivers/net/wireless/quantenna/qtnfmac/pearl/pcie.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -247,7 +247,7 @@ static void qtnf_pcie_free_shm_ipc(struct qtnf_pcie_bus_priv *priv)

		static int qtnf_pcie_init_memory(struct qtnf_pcie_bus_priv *priv)
		{
		int ret;
		int ret = -ENOMEM;

		priv->sysctl_bar = qtnf_map_bar(priv, QTN_SYSCTL_BAR);
		if (IS_ERR_OR_NULL(priv->sysctl_bar)) {