Commit 3e21f4af authored May 16, 2017 by Willy Tarreau Committed by Greg Kroah-Hartman May 16, 2017

char: lp: fix possible integer overflow in lp_setup()

The lp_setup() code doesn't apply any bounds checking when passing
"lp=none", and only in this case, resulting in an overflow of the
parport_nr[] array. All versions in Git history are affected.

Reported-By: Roee Hay <roee.hay@hcl.com>
Cc: Ben Hutchings <ben@decadent.org.uk>
Cc: stable@vger.kernel.org
Signed-off-by: Willy Tarreau <w@1wt.eu>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 2ea659a9

drivers/char/lp.c

+5 −1

Original line number	Diff line number	Diff line
		@@ -859,7 +859,11 @@ static int __init lp_setup (char *str)
		} else if (!strcmp(str, "auto")) {
		parport_nr[0] = LP_PARPORT_AUTO;
		} else if (!strcmp(str, "none")) {
		if (parport_ptr < LP_NO)
		parport_nr[parport_ptr++] = LP_PARPORT_NONE;
		else
		printk(KERN_INFO "lp: too many ports, %s ignored.\n",
		str);
		} else if (!strcmp(str, "reset")) {
		reset = 1;
		}