Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3e1d7fb0 authored by MyungJoo Ham's avatar MyungJoo Ham
Browse files

PM / devfreq: devm_kzalloc to have dev pointer more precisely 



devm_kzalloc of devfreq's statistics data structure has been
using its parent device as the dev allocated for.
If a device's devfreq is disabled in run-time,
such allocated memory won't be freed.

Desginating more precisely with the devfreq device
pointer fixes the issue.

Signed-off-by: default avatarMyungJoo Ham <myungjoo.ham@samsung.com>
parent 33688abb

drivers/devfreq/devfreq.c

+9 −9
Original line number Diff line number Diff line
@@ -561,15 +561,6 @@ struct devfreq *devfreq_add_device(struct device *dev, 
		mutex_lock(&devfreq->lock);

	}



	devfreq->trans_table =	devm_kzalloc(dev, sizeof(unsigned int) *

						devfreq->profile->max_state *

						devfreq->profile->max_state,

						GFP_KERNEL);

	devfreq->time_in_state = devm_kzalloc(dev, sizeof(unsigned long) *

						devfreq->profile->max_state,

						GFP_KERNEL);

	devfreq->last_stat_updated = jiffies;



	dev_set_name(&devfreq->dev, "%s", dev_name(dev));

	err = device_register(&devfreq->dev);

	if (err) {
@@ -578,6 +569,15 @@ struct devfreq *devfreq_add_device(struct device *dev, 
		goto err_out;

	}



	devfreq->trans_table =	devm_kzalloc(&devfreq->dev, sizeof(unsigned int) *

						devfreq->profile->max_state *

						devfreq->profile->max_state,

						GFP_KERNEL);

	devfreq->time_in_state = devm_kzalloc(&devfreq->dev, sizeof(unsigned long) *

						devfreq->profile->max_state,

						GFP_KERNEL);

	devfreq->last_stat_updated = jiffies;



	srcu_init_notifier_head(&devfreq->transition_notifier_list);



	mutex_unlock(&devfreq->lock);