Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3e1a8f10 authored by Fuyun Liang's avatar Fuyun Liang Committed by David S. Miller
Browse files

net: hns3: fix a bug in hns3_driv_to_eth_caps 



The value of link_modes.advertising and the value of link_modes.supported
is initialized to zero every time in for loop in hns3_driv_to_eth_caps().
But we just want to set specified bit for them. Initialization is
unnecessary. This patch fixes it.

Fixes: 496d03e9 (net: hns3: Add Ethtool support to HNS3 driver)
Signed-off-by: default avatarFuyun Liang <liangfuyun1@huawei.com>
Signed-off-by: default avatarLipeng <lipeng321@huawei.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 2b39cabb

drivers/net/ethernet/hisilicon/hns3/hns3pf/hns3_ethtool.c

+2 −7
Original line number Diff line number Diff line
@@ -359,19 +359,14 @@ static void hns3_driv_to_eth_caps(u32 caps, struct ethtool_link_ksettings *cmd, 
		if (!(caps & hns3_lm_map[i].hns3_link_mode))

			continue;



		if (is_advertised) {

			ethtool_link_ksettings_zero_link_mode(cmd,

							      advertising);

		if (is_advertised)

			__set_bit(hns3_lm_map[i].ethtool_link_mode,

				  cmd->link_modes.advertising);

		} else {

			ethtool_link_ksettings_zero_link_mode(cmd,

							      supported);

		else

			__set_bit(hns3_lm_map[i].ethtool_link_mode,

				  cmd->link_modes.supported);

	}

}

}



static int hns3_get_sset_count(struct net_device *netdev, int stringset)

{