Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3e14c6ab authored by Dmitry Vyukov's avatar Dmitry Vyukov Committed by Greg Kroah-Hartman
Browse files

kobject: don't use WARN for registration failures 



This WARNING proved to be noisy. The function still returns an error
and callers should handle it. That's how most of kernel code works.
Downgrade the WARNING to pr_err() and leave WARNINGs for kernel bugs.

Signed-off-by: default avatarDmitry Vyukov <dvyukov@google.com>
Reported-by: default avatar <syzbot+209c0f67f99fec8eb14b@syzkaller.appspotmail.com>
Reported-by: default avatar <syzbot+7fb6d9525a4528104e05@syzkaller.appspotmail.com>
Reported-by: default avatar <syzbot+2e63711063e2d8f9ea27@syzkaller.appspotmail.com>
Reported-by: default avatar <syzbot+de73361ee4971b6e6f75@syzkaller.appspotmail.com>
Cc: stable <stable@vger.kernel.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent df9267f1

lib/kobject.c

+5 −6
Original line number Diff line number Diff line
@@ -233,11 +233,10 @@ static int kobject_add_internal(struct kobject *kobj) 


		/* be noisy on error issues */

		if (error == -EEXIST)

			WARN(1,

			     "%s failed for %s with -EEXIST, don't try to register things with the same name in the same directory.\n",

			pr_err("%s failed for %s with -EEXIST, don't try to register things with the same name in the same directory.\n",

			       __func__, kobject_name(kobj));

		else

			WARN(1, "%s failed for %s (error: %d parent: %s)\n",

			pr_err("%s failed for %s (error: %d parent: %s)\n",

			       __func__, kobject_name(kobj), error,

			       parent ? kobject_name(parent) : "'none'");

	} else