Commit 3def0344 authored May 20, 2017 by Nicolas Iooss Committed by Masahiro Yamada Jun 06, 2017

genksyms: add printf format attribute to error_with_pos()



When compiling with -Wsuggest-attribute=format in HOSTCFLAGS, gcc
complains that error_with_pos() may be declared with a printf format
attribute:

    scripts/genksyms/genksyms.c:726:3: warning: function might be
    possible candidate for ‘gnu_printf’ format attribute
    [-Wsuggest-attribute=format]
       vfprintf(stderr, fmt, args);
       ^~~~~~~~

This would allow catching printf-format errors at compile time in
callers to error_with_pos(). Add this attribute.

Signed-off-by: Nicolas Iooss <nicolas.iooss_linux@m4x.org>
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>

parent 08332893

scripts/genksyms/genksyms.h

+1 −1

Original line number	Diff line number	Diff line
		@@ -75,7 +75,7 @@ struct string_list copy_list_range(struct string_list start,
		int yylex(void);
		int yyparse(void);

		void error_with_pos(const char *, ...);
		void error_with_pos(const char *, ...) __attribute__ ((format(printf, 1, 2)));

		/----------------------------------------------------------------------/
		#define xmalloc(size) ({ void *__ptr = malloc(size); \