Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3db272c0 authored by Li Zefan's avatar Li Zefan Committed by Ingo Molnar
Browse files

perf cgroup: Fix leak of file reference count 



In perf_cgroup_connect(), fput_light() is missing in a failure path.

Signed-off-by: default avatarLi Zefan <lizf@cn.fujitsu.com>
Acked-by: default avatarStephane Eranian <eranian@google.com>
Signed-off-by: default avatarPeter Zijlstra <a.p.zijlstra@chello.nl>
LKML-Reference: <4D6F3461.6060406@cn.fujitsu.com>
Signed-off-by: default avatarIngo Molnar <mingo@elte.hu>
parent 940c5b29

kernel/perf_event.c

+5 −2
Original line number Diff line number Diff line
@@ -404,8 +404,10 @@ static inline int perf_cgroup_connect(int fd, struct perf_event *event, 
		return -EBADF;



	css = cgroup_css_from_dir(file, perf_subsys_id);

	if (IS_ERR(css))

		return PTR_ERR(css);

	if (IS_ERR(css)) {

		ret = PTR_ERR(css);

		goto out;

	}



	cgrp = container_of(css, struct perf_cgroup, css);

	event->cgrp = cgrp;
@@ -422,6 +424,7 @@ static inline int perf_cgroup_connect(int fd, struct perf_event *event, 
		/* must be done before we fput() the file */

		perf_get_cgroup(event);

	}

out:

	fput_light(file, fput_needed);

	return ret;

}