Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3cf631b5 authored by Arvind Yadav's avatar Arvind Yadav Committed by David S. Miller
Browse files

isdn: hisax: Fix pnp_irq's error checking for setup_elsa_isapnp 



The pnp_irq() function returns -1 if an error occurs.
pnp_irq() error checking for zero is not correct.

Signed-off-by: default avatarArvind Yadav <arvind.yadav.cs@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent e17aa098

drivers/isdn/hisax/elsa.c

+1 −1
Original line number Original line Diff line number Diff line
@@ -945,7 +945,7 @@ static int setup_elsa_isapnp(struct IsdnCard *card) 
					card->para[1] = pnp_port_start(pnp_d, 0);

					card->para[1] = pnp_port_start(pnp_d, 0);

					card->para[0] = pnp_irq(pnp_d, 0);

					card->para[0] = pnp_irq(pnp_d, 0);





					if (!card->para[0] || !card->para[1]) {

					if (card->para[0] == -1 || !card->para[1]) {

						printk(KERN_ERR "Elsa PnP:some resources are missing %ld/%lx\n",

						printk(KERN_ERR "Elsa PnP:some resources are missing %ld/%lx\n",

						       card->para[0], card->para[1]);

						       card->para[0], card->para[1]);

						pnp_disable_dev(pnp_d);

						pnp_disable_dev(pnp_d);