Commit 3cf0ad02 authored Jan 25, 2012 by Sebastian Andrzej Siewior Committed by Felipe Balbi Feb 09, 2012

usb: gadget: dummy_hcd: don't assign ->desc on error case



If the stream check fails then we leave ep->desc assigend but we return
with an error code. The caller assumes the endpoint is not enabled
(which is the case) but it can not enable it again due to this
assigment.

Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Acked-by: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: Felipe Balbi <balbi@ti.com>

parent d11519ad

drivers/usb/gadget/dummy_hcd.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -514,7 +514,6 @@ static int dummy_enable(struct usb_ep *_ep,
		}

		_ep->maxpacket = max;
		ep->desc = desc;
		if (usb_ss_max_streams(_ep->comp_desc)) {
		if (!usb_endpoint_xfer_bulk(desc)) {
		dev_err(udc_dev(dum), "Can't enable stream support on "
		@@ -523,6 +522,7 @@ static int dummy_enable(struct usb_ep *_ep,
		}
		ep->stream_en = 1;
		}
		ep->desc = desc;

		dev_dbg(udc_dev(dum), "enabled %s (ep%d%s-%s) maxpacket %d stream %s\n",
		_ep->name,