Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3cc54473 authored by Hangyu Hua's avatar Hangyu Hua Committed by Greg Kroah-Hartman
Browse files

net: sched: fix possible refcount leak in tc_chain_tmplt_add() 



[ Upstream commit 44f8baaf230c655c249467ca415b570deca8df77 ]

try_module_get will be called in tcf_proto_lookup_ops. So module_put needs
to be called to drop the refcount if ops don't implement the required
function.

Fixes: 9f407f17 ("net: sched: introduce chain templates")
Signed-off-by: default avatarHangyu Hua <hbh25y@gmail.com>
Reviewed-by: default avatarLarysa Zaremba <larysa.zaremba@intel.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 9b2903fc

net/sched/cls_api.c

+1 −0
Original line number Diff line number Diff line
@@ -1838,6 +1838,7 @@ static int tc_chain_tmplt_add(struct tcf_chain *chain, struct net *net, 
		return PTR_ERR(ops);

	if (!ops->tmplt_create || !ops->tmplt_destroy || !ops->tmplt_dump) {

		NL_SET_ERR_MSG(extack, "Chain templates are not supported with specified classifier");

		module_put(ops->owner);

		return -EOPNOTSUPP;

	}